fix(core): allow number index for hit attribute #1261

[aldenquimby]

Summary

• Fixes HighlightHitParams attribute type should allow number for array indexing #1261

Result

• I am unable to run this project on my Apple Silicon Mac, so I am unable to confirm this works. If a maintainer could help verify, that would be much appreciated

[aldenquimby]

An alternative would be to add @algolia/autocomplete-shared as a dependency in this example project, and import the existing type, so this doesn't need to be duplicated

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0080a87:

Sandbox	Source
@algolia/autocomplete-example-github-repositories-custom-plugin	Configuration
@algolia/autocomplete-example-instantsearch	Configuration
@algolia/autocomplete-example-playground	Configuration
@algolia/autocomplete-example-preview-panel-in-modal	Configuration
@algolia/autocomplete-example-starter-algolia	Configuration
@algolia/autocomplete-example-starter	Configuration
@algolia/autocomplete-example-reshape	Configuration
@algolia/autocomplete-example-vue	Configuration
@algolia/autocomplete-example-playground	Issue #1261

[aldenquimby]

An alternative, if preferred, could be to change this type to:

export type ParseAlgoliaHitParams<TItem> = Pick<HighlightHitParams<TItem>, 'hit' | 'attribute'>;

[Haroenv]

let's go with this solution! ideally we'd do a proper traversal of the Hit to create the highlight types, but in the past that caused issues with types that got too long. This is a good stopgap solution

[aldenquimby]

Thank you @Haroenv