Conversation
…stance of autocomplete
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2c6e81f:
|
sarahdayan
reviewed
Mar 13, 2023
Member
sarahdayan
left a comment
There was a problem hiding this comment.
I realized that we don't document destroy in the docs. Should we add an entry here so we can link it in the warning?
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
FabienMotte
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While autocomplate can technically render multiple instances in the same document, in practice it results in inconsistent behavior when a user interacts with them.
This is because we currently bind pointer events on Window to determine whether a panel should be closed after a user clicks outside of it. This only works for one of the autocomplete added to the document.
Until we find a way to handle that, and to make customers aware of this limitation, this PR displays a warning in dev when there are more than a single instance of Autocomplete on a document.