Fix tests for rustc 1.82-beta #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Should we switch to a stable hash-algorithm instead? We already depend on the sha1 crate so we could use that?
Owner
Author
|
Could we chop it down to not be super long and still preserve enough entropy? |
Collaborator
|
We also depend on |
Owner
Author
|
Let's merge this and open a new PR exploring a stable hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc 1.82-beta in this commit changes something about how hashes are calculated (likely this PR). Since our tests have pinned hash values, we get a breakage.
Since we uphold MSRV 1.65, we can't pin the hash in the test since we will get broken CI tests when we ensure the MSRV compiles.