Conversation
alexscheitlin
approved these changes
Nov 19, 2019
Owner
alexscheitlin
left a comment
There was a problem hiding this comment.
Nice one, I didn't know that.
meck93
approved these changes
Nov 19, 2019
0255b65 to
615314d
Compare
615314d to
2368eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request explained:
husky&lint-stagednever worked correctly with our setup, nothing was formatted each time we committed. Even tough thepre-commithook was fired it did not recognize any staged files.huskyfrom the sub-repos and only install it at the top-levellernahttps://github.com/lerna/lerna, the Nr. 1 tool to manage monoreposnpm scriptsin sub-repos simultaneouslylerna.jsonholds some minor configs, most importantly the"packages":[ ... ], that tell where our repos arepackage.jsonwith thehuskyhookpre-commit, which will then run thepre-commitcommand in each sub-repopre-commitscript of every sub-repo is run