[component] Add return code constants for FW auto update to component_base#2
Closed
alexrallen wants to merge 1 commit intomasterfrom
Closed
[component] Add return code constants for FW auto update to component_base#2alexrallen wants to merge 1 commit intomasterfrom
alexrallen wants to merge 1 commit intomasterfrom
Conversation
keboliu
approved these changes
May 26, 2021
dgsudharsan
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added constants to component_base for each potential return code of
auto_firmware_update()so that vendor specific component implementations may reference these to provide the correct return codes to the firmware auto update utility.Motivation and Context
This provides a central location from which standardized return codes may be imported, preventing the need for potential inconsistency in vendor implementations or the use of magic numbers in vendor implementations for return code.
How Has This Been Tested?
Non-functional change, builds successfully and can be successfully imported from at runtime.