[ntp] Fix ntp.conf template to allow setting of source port in CONFIG_DB#5
Closed
alexrallen wants to merge 1 commit intomasterfrom
Closed
[ntp] Fix ntp.conf template to allow setting of source port in CONFIG_DB#5alexrallen wants to merge 1 commit intomasterfrom
alexrallen wants to merge 1 commit intomasterfrom
Conversation
dgsudharsan
approved these changes
May 6, 2021
Collaborator
|
thanks. if CI is passing lets go with upstreaming it. |
alexrallen
pushed a commit
that referenced
this pull request
Oct 29, 2021
Also add out of tree pca9548 mux driver to use platform data to mapping i2c bus with front panel port. Signed-off-by: Jakkapan Jangmuang <jjangmua@celestica.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com>
alexrallen
pushed a commit
that referenced
this pull request
Nov 5, 2021
Also add out of tree pca9548 mux driver to use platform data to mapping i2c bus with front panel port. Signed-off-by: Jakkapan Jangmuang <jjangmua@celestica.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com>
alexrallen
pushed a commit
that referenced
this pull request
Nov 17, 2021
Also add out of tree pca9548 mux driver to use platform data to mapping i2c bus with front panel port. Signed-off-by: Jakkapan Jangmuang <jjangmua@celestica.com> Co-authored-by: Saikrishna Arcot <sarcot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently, there is a bug in the ntp.conf jinja2 template where it will ignore the
src_intfdirective in CONFIG_DB if there are multiple IP addresses associated with an interface. This code change fixes that bug and allows the template to select the correct source interface for NTP.How I did it
I did this by modifying the macro in
ntp.conf.j2which determines if there is an ip address associated with an interface to set a state variable when it detects a valid interface entry in CONFIG_DB instead of outputting "true" directly (which could result in multiple "trues" outputted for interfaces with multiple valid IP addresses).How to verify it
Add two ipv4 addresses to an interface in SONiC
Add the following configuration to
config_db.jsonReplace
Ethernet1with the interface name of the one you assigned the IP addresses to.Run
sudo config reload -yOpen
/etc/ntp.confand verify that the following line existsThe interface specified should be the one set in the previous steps.
Description for the changelog
[ntp] Fix ntp.conf template to allow setting of source port in CONFIG_DB
A picture of a cute animal (not mandatory but encouraged)