[mellanox] Remove redundant breakout mode for SN3800#27
Closed
alexrallen wants to merge 1 commit intomasterfrom
Closed
[mellanox] Remove redundant breakout mode for SN3800#27alexrallen wants to merge 1 commit intomasterfrom
alexrallen wants to merge 1 commit intomasterfrom
Conversation
alexrallen
changed the title
dgsudharsan
approved these changes
Feb 1, 2022
alexrallen
pushed a commit
that referenced
this pull request
Mar 24, 2022
ce72b0d Longxiang Lyu Thu Feb 24 06:05:12 2022 Put handler member functions as virtual in base (#30) ef59e4f Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) 2d12892 Longxiang Lyu Wed Feb 16 03:32:06 2022 Rename LinkManagerStateMachine to ActiveStandbyStateMachine (#26) f38634c Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) a8434dd Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 2ebdb2b Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)
alexrallen
pushed a commit
that referenced
this pull request
Mar 30, 2022
Changes: Update submodule branch to 202012 [sonic-linkmgrd][202012] submodule update a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) 05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24) sign-off: Jing Zhang [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
With sonic-net#9278 we no longer need to specify breakout modes with a different default speed separately.
How I did it
Removed discrete 1x10G breakout mode from SN3800 platform.json file
How to verify it
Apply the Mellanox-SN3800-D28C49S1 SKU and verify all ports are configured as expected.
Which release branch to backport (provide reason below if selected)
The mentioned fix was backported to 202111 so I figure this should be backported as well to be aligned.
sonic-net@546818f
Description for the changelog
[mellanox] Remove redundant breakout mode for SN3800
A picture of a cute animal (not mandatory but encouraged)