Add D100C12S2 sku to SN4600C by alexrallen · Pull Request #14 · alexrallen/sonic-buildimage

alexrallen · 2021-09-10T01:27:36Z

Why I did it

New SKU by customer request.

4   100G Downlinks
2   10G  Downlinks
100 50G  Downlinks (2x Split)
8   100G Uplinks

How I did it

Duplicated existing 4600C SKU and updated

Port Speeds
Buffer Default Values
Default Breakout Modes
SAI Profile Speeds & Breakout Capabilities

How to verify it

Tested on 4600C with hardware loopback connections.

Which release branch to backport (provide reason below if selected)

For the purposes of internal review this is based against master. A PR will be submitted individually against 202012 and 202106 / master.

Description for the changelog

[mellanox] Add D100C12S2 SKU to 4600C

A picture of a cute animal (not mandatory but encouraged)

stephenxs · 2021-09-10T10:51:13Z

The numbers are correct.
Better to update the description to:

4  100G Downlinks
2  10G  Downlinks
100 50G  Downlinks
8  100G Uplinks

pg_profile_lookup.ini should be a symbol link to the same file in Mellanox-SN4600C-D112C8

alexrallen · 2021-09-10T14:30:25Z

The numbers are correct.
Better to update the description to:
4  100G Downlinks
2  10G  Downlinks
100 50G  Downlinks
8  100G Uplinks
pg_profile_lookup.ini should be a symbol link to the same file in Mellanox-SN4600C-D112C8

This has been resolved by the latest commit.

stephenxs

Approved for buffer configurations.
Please check with other reviewers as well.

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/port_config.ini

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/sai.profile

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/hwsku.json

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/port_config.ini

alexrallen · 2021-09-10T23:00:56Z

@dgsudharsan @vivekreddynv Updated per feedback.

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/hwsku.json

stephenxs

Approved for buffer with 2km supported.

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com> Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com> Co-authored-by: Petro Bratash <petrox.bratash@intel.com> Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

[sonic-linkmgrd][master] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang zhangjing@microsoft.com

[sonic-linkmgrd][202012] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang zhangjing@microsoft.com

Add D100C12S2 sku to SN4600C

3ac3d95

Update pg_profile_lookup.ini to be symlink

3c7ff96

stephenxs approved these changes Sep 10, 2021

View reviewed changes

dgsudharsan requested changes Sep 10, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/port_config.ini Outdated Show resolved Hide resolved

vivekrnv reviewed Sep 10, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/sai.profile Show resolved Hide resolved

vivekrnv reviewed Sep 10, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/hwsku.json Outdated Show resolved Hide resolved

vivekrnv reviewed Sep 10, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/port_config.ini Outdated Show resolved Hide resolved

Address review comments

eeb4ab8

alexrallen requested a review from dgsudharsan September 10, 2021 23:02

vivekrnv approved these changes Sep 10, 2021

View reviewed changes

Add line breaks

8b0aa94

dgsudharsan reviewed Sep 11, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-D100C12S2/hwsku.json Show resolved Hide resolved

alexrallen added 2 commits September 13, 2021 15:49

Update to 2km cables on t1. Add 1x10G to 4600C platform.json

1e22f73

Fix EOL issues

8644e72

alexrallen requested review from dgsudharsan and stephenxs September 13, 2021 18:59

stephenxs approved these changes Sep 13, 2021

View reviewed changes

vivekrnv approved these changes Sep 13, 2021

View reviewed changes

dgsudharsan approved these changes Sep 13, 2021

View reviewed changes

dgsudharsan closed this Sep 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add D100C12S2 sku to SN4600C#14

Add D100C12S2 sku to SN4600C#14
alexrallen wants to merge 6 commits intomasterfrom
sku_SN4600C-D100C12S2

alexrallen commented Sep 10, 2021 •

edited

Loading

Uh oh!

stephenxs commented Sep 10, 2021

Uh oh!

alexrallen commented Sep 10, 2021

Uh oh!

stephenxs left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexrallen commented Sep 10, 2021

Uh oh!

Uh oh!

stephenxs left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alexrallen commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

stephenxs commented Sep 10, 2021

Uh oh!

alexrallen commented Sep 10, 2021

Uh oh!

stephenxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexrallen commented Sep 10, 2021

Uh oh!

Uh oh!

stephenxs left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexrallen commented Sep 10, 2021 •

edited

Loading