Open
Conversation
dpc
reviewed
Oct 16, 2025
| /// Sends a GET request to the given `url`, retrying failed attempts | ||
| /// for retryable error codes until max retries hit. | ||
| async fn get_with_retry(&self, url: &str) -> Result<Response, Error> { | ||
| async fn get_with_retry(&self, url: &str) -> Result<http::Response<Vec<u8>>, Error> { |
There was a problem hiding this comment.
Maybe it's possible to convert http::Response to reqwest::Response, hopefully avoiding this change and all the other one it causes.
dpc
reviewed
Oct 16, 2025
| .expect("Failed to encapsulate request"); | ||
| match self | ||
| .client | ||
| .post("https://relay.com") |
There was a problem hiding this comment.
This should be provided via constructor of esplora_client::Client, optionally, I think?
dpc
reviewed
Oct 16, 2025
| @@ -0,0 +1,69 @@ | |||
| use bitcoin_ohttp as ohttp; | |||
There was a problem hiding this comment.
@DanGould shouldn't this be just a public api that we can use, instead of having to copy&paste it?
dpc
reviewed
Oct 16, 2025
|
|
||
| # default async runtime | ||
| tokio = { version = "1", features = ["time"], optional = true } | ||
| bitcoin-ohttp = "0.6.0" |
There was a problem hiding this comment.
This could be an optional compile time feature&dependency.
|
If this is available in esplora_client, then we are definitely going to use it in Fedimint's client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coauthored with @DanGould
cc @ChristopherA @dpc