Fix dirvish-yank error when copying a file in the same directory #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
When yanking marked files into the same directory the expected behavior is to be prompted with a list of options. Instead an error occurs:
Cause
The first condition of the
condfunction checks if thesrcanddestare equal, then aniffunction that checks forsymlinkmethod is called and it's else branch returns an error if not.When yanking a file into the same directory
srcis always equal todestbut themethodis not any of thesymlink, thus causing theifto always fall into theelsebranch and exiting with error.Solution
Do not prompt for an error, just create a condition for the
condfunction that checks thatsrc == dest AND method == symlink.Proposed feature in this PR
I found this while trying to create duplicates of a file, I saw this is not implemented, so embedded to this PR there is a proposal for adding a "duplicate file" option in the yank menu.