Skip to content

Conversation

@fuskovic
Copy link
Member

Closes: #5045

@fuskovic fuskovic added this to the v1.7.6 milestone Sep 23, 2025
@fuskovic fuskovic self-assigned this Sep 23, 2025
@fuskovic fuskovic requested a review from a team as a code owner September 23, 2025 17:22
@fuskovic fuskovic added kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/high Needs to be addressed sooner rather than later labels Sep 23, 2025
@netlify
Copy link

netlify bot commented Sep 23, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit c7e32d8
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/68de8ce3105f130008adfa73
😎 Deploy Preview https://deploy-preview-5093.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.13%. Comparing base (9cd0158) to head (c7e32d8).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/stages/regular_stages.go 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5093      +/-   ##
==========================================
+ Coverage   55.07%   55.13%   +0.05%     
==========================================
  Files         400      401       +1     
  Lines       35205    35661     +456     
==========================================
+ Hits        19390    19662     +272     
- Misses      14865    15038     +173     
- Partials      950      961      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fuskovic fuskovic requested a review from krancour September 24, 2025 14:40
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
@fuskovic fuskovic requested a review from krancour September 24, 2025 17:51
@fuskovic fuskovic added the area/controller Affects the (main) controller label Sep 24, 2025
@krancour
Copy link
Member

krancour commented Sep 24, 2025

@fuskovic apart from #5093 (comment), please just give this an e2e test-drive to make sure you don't get stuck reconciling if:

  • Stage hasn't had any Promotions yet F.H.
  • A Promotion is currently in-progress F.H.
  • Last Promotion failed F.H.
  • Last Promotion succeeded but didn't have any health checks (you can do this by not involving Argo CD in your promotion process) F.H.

After that sanity check, this looks g2g.

Signed-off-by: fuskovic <[email protected]>
@fuskovic fuskovic requested a review from krancour September 30, 2025 17:50
@fuskovic fuskovic requested a review from krancour October 2, 2025 14:23
Signed-off-by: fuskovic <[email protected]>
@krancour
Copy link
Member

krancour commented Oct 2, 2025

I've discovered a new bug this introduces. If health assesses to Unknown, it will block verification indefinitely.

I'm thinking about the best way to deal with this...

@krancour
Copy link
Member

krancour commented Oct 2, 2025

Closing this. Explanation here: #5045 (comment)

@krancour krancour closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Affects the (main) controller kind/bug Something isn't working as intended; If unsure that something IS a bug, start a discussion instead priority/high Needs to be addressed sooner rather than later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should Stage health evaluated be a ERROR in the kargo-controller?

3 participants