-
Notifications
You must be signed in to change notification settings - Fork 296
fix: return nil err when there are no healthchecks #5093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: fuskovic <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5093 +/- ##
==========================================
+ Coverage 55.07% 55.13% +0.05%
==========================================
Files 400 401 +1
Lines 35205 35661 +456
==========================================
+ Hits 19390 19662 +272
- Misses 14865 15038 +173
- Partials 950 961 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Kent Rancourt <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
Signed-off-by: fuskovic <[email protected]>
8fbe003 to
384043f
Compare
|
@fuskovic apart from #5093 (comment), please just give this an e2e test-drive to make sure you don't get stuck reconciling if:
After that sanity check, this looks g2g. |
Signed-off-by: fuskovic <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
Signed-off-by: fuskovic <[email protected]>
|
I've discovered a new bug this introduces. If health assesses to Unknown, it will block verification indefinitely. I'm thinking about the best way to deal with this... |
|
Closing this. Explanation here: #5045 (comment) |
Closes: #5045