Refactor KafkaConsumerActor event handling from Mailbox to direct method call#418
Merged
Merged
Conversation
This reverts commit d926fe1.
Aaronontheweb
approved these changes
Jan 22, 2025
| .RunWith(Sink.Last<int>(), Materializer); | ||
|
|
||
| var consumedMessages = await consumedMessagesTask.ShouldCompleteWithin(10.Seconds()); | ||
| var consumedMessages = await consumedMessagesTask.ShouldCompleteWithin(60.Seconds()); |
| public void OnLost(IImmutableSet<TopicPartitionOffset> revokedTopicPartitions, | ||
| IRestrictedConsumer consumer) | ||
| { | ||
| RevokeEventsCounter.IncrementAndGet(); |
| return true; | ||
|
|
||
| // Rebalance callbacks | ||
| case PartitionAssigned evt: |
Member
There was a problem hiding this comment.
LGTM - this has all be moved to the event-handler code
Arkatufus
added a commit
to Arkatufus/Akka.Streams.Kafka
that referenced
this pull request
Feb 28, 2025
Arkatufus
added a commit
to Arkatufus/Akka.Streams.Kafka
that referenced
this pull request
Feb 28, 2025
# Conflicts: # src/Akka.Streams.Kafka/Extensions/CollectionExtensions.cs # src/Akka.Streams.Kafka/Stages/Consumers/Actors/KafkaConsumerActor.cs
Merged
Aaronontheweb
added a commit
to Arkatufus/Akka.Streams.Kafka
that referenced
this pull request
Mar 3, 2025
Aaronontheweb
added a commit
that referenced
this pull request
Mar 3, 2025
* Implement OnPartitionsLost event handler from #418 * Bump AkkaVersion to 1.5.37 (#422) (cherry picked from commit d2aa70f) * Implement dual targeting for netstandard2.0 and net6.0 (#424) (cherry picked from commit 6c895c5) * Cleanup linq by introducing Partition (#425) * Make sure that we prevent downstream to propagate null completion exception (#427) (cherry picked from commit 562212d) * Update RELEASE_NOTES.md for 1.5.37 release (#423) * Update RELEASE_NOTES.md for 1.5.37 release * Update RELEASE_NOTES.md (cherry picked from commit d6b0a42) * Bump Confluent.Kafka to 2.8.0 (#428) (cherry picked from commit 02c002e) * Make sure that restricted consumer is populated properly (#429) (cherry picked from commit 8e41f71) * Add CancellationToken support to MockCustomer (#430) (cherry picked from commit 2d11235) * Fix missing OnPartitionLost handler * Simplify exception handling --------- Co-authored-by: Aaron Stannard <[email protected]>
Aaronontheweb
added a commit
that referenced
this pull request
Mar 3, 2025
Aaronontheweb
added a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #414 and #415
Changes
Self.Tell()to direct method call