Issue 24519: Created method lazilyAsync for both DSLs and adds section in docs #24568

kelebra · 2018-02-20T05:04:12Z

This PR addresses issue #24519. Open questions so far:

Does this one deserve on its own class level implementation (like LazySource and friends)?
Should it be added to Cookbook (stream-cookbook.md)?

…n in docs.

akka-ci · 2018-02-20T05:06:03Z

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

ktoso · 2018-02-20T05:09:40Z

OK TO TEST

ktoso

Almost there, please add a test too

ktoso · 2018-02-20T05:25:15Z

akka-docs/src/main/paradox/stream/stages-overview.md

+
+---------------------------------------------------------------
+
+### actorPublisher


This should not be here anymore :)

Ooops, removed.

ktoso · 2018-02-20T05:25:43Z

akka-stream/src/main/scala/akka/stream/javadsl/Source.scala

+   * Creates a `Source` from supplied future factory that is not called until downstream demand. When source gets
+   * materialized the materialized future is completed with the value from the factory. If downstream cancels or fails
+   * without any demand the create factory is never called and the materialized `Future` is failed.
+   */


Add a link to the normal one

ktoso · 2018-02-20T05:26:52Z

akka-stream/src/main/scala/akka/stream/scaladsl/Source.scala

+   * materialized the materialized future is completed with the value from the factory. If downstream cancels or fails
+   * without any demand the create factory is never called and the materialized `Future` is failed.
+   */
+  def lazilyAsync[T](create: () ⇒ CompletionStage[T]): Source[T, Future[NotUsed]] =


This should work on Scala.concurrent.Future :)

Makes sense, also done.

akka-ci · 2018-02-20T05:56:51Z

Test PASSed.

kelebra · 2018-02-21T01:02:41Z

Sure, was on it. Added unit tests similar to the ones from LazySourceSpec.

akka-ci · 2018-02-21T01:22:26Z

Test PASSed.

akka-ci · 2018-02-21T01:52:36Z

Test PASSed.

ktoso · 2018-02-21T03:05:42Z

akka-stream-tests/src/test/scala/akka/stream/scaladsl/LazilyAsyncSpec.scala

@@ -0,0 +1,77 @@
+package akka.stream.scaladsl


All files must have the header:

/** * Copyright (C) 2014-2018 Lightbend Inc. <https://www.lightbend.com> */

We'll soon automate that I hope

Added but also see that you did that already, sorry for kind of a mess :(

Oh, sorry -- I somehow expected you be in EU timezone so was taking my time prepping and going to merge this while EU is asleep :)

CST actually :) but thanks for taking care of it, much appreciated

Also, I could work on automating copyright check if you can supply issue for it

Cheers to CST from JST then :)

For the copyright we want to replicate what we have here: akka/akka-http#1738

akka-ci · 2018-02-21T03:52:29Z

Test PASSed.

ktoso · 2018-02-21T04:06:33Z

Does this one deserve on its own class level implementation (like LazySource and friends)?

Nope, it's good as is.

Should it be added to Cookbook (stream-cookbook.md)?

Nope, it's enough to have it in the overview doc. Cookbook is for "this is how you can put together a number of things to achieve some thing"

ktoso · 2018-02-21T04:08:43Z

LGTM, simple enough that we can merge once validated I think 👍

akka-ci · 2018-02-21T04:47:58Z

Test PASSed.

kelebra · 2018-02-21T18:09:09Z

I think all issues highlighted in PR were addressed. Is there anything else required for this PR to be merged?

ktoso · 2018-02-22T01:15:21Z

Lookin good, thanks 👍

Issue 24519: Created method lazilyAsync for both DSLs and adds sectio…

6a548fd

…n in docs.

Merge branch 'master' into issue/24519

5e897fc

akka-ci added the validating PR is currently being validated by Jenkins label Feb 20, 2018

ktoso reviewed Feb 20, 2018

View reviewed changes

akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 20, 2018

Issue 24519: Changes according to code review

cb81338

akka-ci added validating PR is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Feb 21, 2018

Issue 24519: Added unit tests

3375538

akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 21, 2018

akka-ci added the tested PR that was successfully built and tested by Jenkins label Feb 21, 2018

ktoso reviewed Feb 21, 2018

View reviewed changes

Update LazilyAsyncSpec.scala

b588d16

akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Feb 21, 2018

kelebra added 2 commits February 20, 2018 21:54

Issue 24519: Added copyright

b696b8c

Merge remote-tracking branch 'origin/issue/24519' into issue/24519

fbbe622

akka-ci added the validating PR is currently being validated by Jenkins label Feb 21, 2018

akka-ci removed the tested PR that was successfully built and tested by Jenkins label Feb 21, 2018

ktoso approved these changes Feb 21, 2018

View reviewed changes

akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Feb 21, 2018

ktoso merged commit 80da4ca into akka:master Feb 22, 2018

kelebra mentioned this pull request Feb 22, 2018

Added integration with sbt-header like in akka-http #24594

Closed


		---------------------------------------------------------------

		### actorPublisher

Issue 24519: Created method lazilyAsync for both DSLs and adds section in docs #24568

Issue 24519: Created method lazilyAsync for both DSLs and adds section in docs #24568

Uh oh!

Conversation

kelebra commented Feb 20, 2018

Uh oh!

akka-ci commented Feb 20, 2018

Uh oh!

ktoso commented Feb 20, 2018

Uh oh!

ktoso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akka-ci commented Feb 20, 2018

Uh oh!

kelebra commented Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akka-ci commented Feb 21, 2018

Uh oh!

akka-ci commented Feb 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ktoso Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akka-ci commented Feb 21, 2018

Uh oh!

ktoso commented Feb 21, 2018

Uh oh!

ktoso commented Feb 21, 2018

Uh oh!

akka-ci commented Feb 21, 2018

Uh oh!

kelebra commented Feb 21, 2018

Uh oh!

ktoso commented Feb 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kelebra commented Feb 21, 2018 •

edited

Loading

ktoso Feb 21, 2018 •

edited

Loading