-
Notifications
You must be signed in to change notification settings - Fork 49
Closed
Labels
bugSomething isn't workingSomething isn't workingpriority/mediumDefault priority for itemsDefault priority for itemsready for reviewChange related to the issue is ready for reviewChange related to the issue is ready for review
Milestone
Description
Describe the bug
Many errors simply ignored on redfish calls -
e.g. media injection returns 400 but we say success
Expected behavior
Errors should be bubbled up so we can define the appropriate response to errors.
It appears some of the errors can be treated as warning or simple ignored.
Currently
- We verify the http response code and throw an error if it's not 200 or 204.
- The redfish client likes to return non-nil errors on success, so checking err is not always reliable
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpriority/mediumDefault priority for itemsDefault priority for itemsready for reviewChange related to the issue is ready for reviewChange related to the issue is ready for review