fix issue 243, app built on Windows cannot find manifest.json at startup and hangs on logo screen.#244
Open
lxgsbqylbk wants to merge 1 commit intoairgap-it:masterfrom
Open
fix issue 243, app built on Windows cannot find manifest.json at startup and hangs on logo screen.#244lxgsbqylbk wants to merge 1 commit intoairgap-it:masterfrom
lxgsbqylbk wants to merge 1 commit intoairgap-it:masterfrom
Conversation
…Windows where the built app cannot find manifest.json at startup and hangs.
lxgsbqylbk
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a system-independent path separator to get namespace name, otherwise building the project on Windows will generate incorrect manifest.json asset paths
public/assets/protocol_modules/node_modules/@airgap-community/iso-rootstock/manifest.jsoncausing the app to hang at startup on the device because it cannot find manifest.json
public/assets/protocol_modules/iso-rootstock/manifest.jsonOn the Windows platform, the path separator is '\\' instead of '/'
This issue causes the app to hang on the logo screen at startup.
fix issue #243