Adds static framework generation on CI #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What use case do you have in mind for a static XCFramework? |
|
We use Tuist for development, which suggests using a static framework for SPM dependencies by default - https://docs.tuist.dev/en/guides/develop/projects/dependencies#tuists-xcodeprojbased-integration. In addition, the release application is built in static to avoid wasting time loading dynamic libraries on startup. It seemed to me that it would be convenient for such a set-up to have a static framework in addition to the pre-built dynamic framework. Artifact download URL: https://github.com/airbnb/lottie-ios/actions/runs/14942555625/artifacts/3098429181 |
|
Sounds good, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds static framework generation on CI.
Fixes: #2485 and #2486
Additionally later, can be added to https://github.com/airbnb/lottie-spm
I would be grateful if you could double-check the code, I don't work with ruby that often.
Example output of a type of framework for dynamic linking:
Example of framework type output for static linking:
