Support customizing contentsScale of text layer
#2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Version | Download | Change | Install | Change | Approval |
|---|---|---|---|---|---|---|
| SizeTest com.airbnb.lottie.sizetest.iOS |
1.0 (1) | 758.9 kB | ⬇️ 27 B | 2.3 MB | ⬆️ 366 B (0.02%) | N/A |
SizeTest 1.0 (1)
com.airbnb.lottie.sizetest.iOS
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 366 B (0.02%)
Total download size change: ⬇️ 27 B
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬆️ 366 B |
View Treemap
🛸 Powered by Emerge Tools
miguel-jimenez-0529
approved these changes
Apr 28, 2025
Comment on lines
17
to
16
| var precision: Float = 1 | ||
| var precision: Float = 0.985 |
There was a problem hiding this comment.
Should we add a comment about why this is not 1?
calda
commented
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for customizing the
contentsScaleof text layers, to control text rendering sharpness.Text in the animation below is aliased poorly because of how the text layer is being rasterized at a high resolution and then downscaled. As a workaround, we can reduce the
contentsScaleof the layer in our feature code.Before
After, with customized
contentsScale = 0.25