Fix issue where animation with justified text justification would fail to parse #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Apr 1, 2025
Comment on lines
+14
to
+17
| case justifyLastLineLeft | ||
| case justifyLastLineRight | ||
| case justifyLastLineCenter | ||
| case justifyLastLineFull |
There was a problem hiding this comment.
miguel-jimenez-0529
approved these changes
Apr 28, 2025
Comment on lines
+2
to
+3
| [0] The Core Animation rendering engine does not support animating multiple keyframes for text layer text values, due to limitations of Core Animation. | ||
| [0] The Core Animation rendering engine does not support animating multiple keyframes for text layer text values, due to limitations of Core Animation. No newline at end of file |
There was a problem hiding this comment.
This looks duplicated
There was a problem hiding this comment.
Generated output from the snapshot test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where an animation with
justifiedtext justification would fail to parse.The schema supports values
3,4,5, and6(different "justified" values) for text justification, but we previously only allowed0,1, or2(left, right, center).Fixes #2545.