Skip to content

add a switch to ignore internal image cache #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 7, 2023
Merged

add a switch to ignore internal image cache #2171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
805ce08
feature: add a switch to ignore internal image cache or not , in imag…
JerryFans Sep 7, 2023
efddb6f
fix property describe and format code.
JerryFans Sep 7, 2023
03731ae
Apply suggestions from code review
calda Sep 7, 2023
c401002
Apply suggestions from code review
calda Sep 7, 2023
93f5aaa
fix cacheEligible only get need.
JerryFans Sep 7, 2023
bf60eae
Merge branch 'master' of github.com:JerryFans/lottie-ios
JerryFans Sep 7, 2023
9155de3
if not cacheEligible, return custom image provider.
JerryFans Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Private/MainThread/LayerContainers/Utility/CachedImageProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ private final class CachedImageProvider: AnimationImageProvider {
// MARK: Public

public func imageForAsset(asset: ImageAsset) -> CGImage? {
if let image = imageCache.object(forKey: asset.id as NSString) {
if imageProvider.ignoreInternalImageCache == false, let image = imageCache.object(forKey: asset.id as NSString) {
return image
}
if let image = imageProvider.imageForAsset(asset: asset) {
Expand Down
10 changes: 10 additions & 0 deletions Sources/Public/ImageProvider/AnimationImageProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,15 @@ import Foundation
/// Additionally custom Image Providers can be made to load images from a URL,
/// or to Cache images.
public protocol AnimationImageProvider {

var ignoreInternalImageCache: Bool { get set }

func imageForAsset(asset: ImageAsset) -> CGImage?
}

public extension AnimationImageProvider {
var ignoreInternalImageCache: Bool {
get { return false }
set { }
}
}