Skip to content

Fixing assert on backfillStartDate #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing assert on backfillStartDate #940

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87d7731
fixing assert on overrideStartPartition
knarukulla Mar 11, 2025
39dba54
Merge branch 'main' into issues-939
krisnaru Mar 11, 2025
c96040b
Merge branch 'main' into issues-939
krisnaru Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spark/src/main/scala/ai/chronon/spark/GroupBy.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,10 @@ object GroupBy {
overrideStartPartition: Option[String] = None,
skipFirstHole: Boolean = true): Unit = {
assert(
groupByConf.backfillStartDate != null,
s"GroupBy:${groupByConf.metaData.name} has null backfillStartDate. This needs to be set for offline backfilling.")
groupByConf.backfillStartDate != null || overrideStartPartition != null,
s"GroupBy:${groupByConf.metaData.name} has null backfillStartDate or overrideStartPartition." +
s" This needs to be set for offline backfilling."
)
groupByConf.setups.foreach(tableUtils.sql)
val overrideStart = overrideStartPartition.getOrElse(groupByConf.backfillStartDate)
Copy link
Collaborator

@pengyu-hou pengyu-hou Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the group by backfill start date is meant for DAG and task scheduling purpose. If there is no such parameter, we should not even enter the group by backfill mode.

And the start partition override is implemented at line 694 already.

val outputTable = groupByConf.metaData.outputTable
Expand Down