Improve contentOffsetAdjustment behavior #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
commented
Oct 10, 2025
| at: ElementLocation(indexPath: preferredAttributes.indexPath), | ||
| .afterUpdates).height | ||
| attributes.frame.origin.y -= (contentOffsetAdjustment?.y ?? 0) | ||
| .afterUpdates) |
There was a problem hiding this comment.
much simpler - the math before was unnecessarily complex
brynbodayle
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes some issues with calculating targetContentOffset, which specifically affected the bottomToTop layout used for message-like UIs.
In my next PR, I'm going to improve how we track state as batch updates and other invalidations occur. I have this working in a prototype layout, and the ideas should translate well to MagazineLayout.
Tested in example app and Airbnb app.
Types of changes