Inconsistent behaviour between Cython and CPython (or lack of docs, or both) #991
Conversation
|
We should really finish up #860 to catch the differences better... |
tests/test_url_parsing.py
Outdated
| assert u.query_string == "" | ||
| assert u.fragment == "Pünktelchen\udca0\udcef\udcb6" | ||
| assert u.path == u2.path | ||
| # assert u.fragment == u2.fragment |
There was a problem hiding this comment.
| # assert u.fragment == u2.fragment |
| assert u.query_string == "" | ||
| assert u.fragment == "" | ||
|
|
||
| def test_truncated_utf_sequence(self): |
There was a problem hiding this comment.
If path is the only difference, could you parametrize the test?
webknjaz
force-pushed
the
test-cmod-utfseq
branch
from
bc8a244 to
753781a
Compare
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (44.00%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 95.88% 95.83% -0.06%
==========================================
Files 27 27
Lines 5303 5331 +28
Branches 316 316
==========================================
+ Hits 5085 5109 +24
- Misses 192 196 +4
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #991 will not alter performanceComparing Summary
|
3 participants
What do these changes do?
Adds a test for the quoting inconsistency that I believe needs change. It is written such that the compiled module passes but setting
YARL_NO_EXTENSIONS=1fails.Submitting without the desired change to verify CI results. May or may not add actual content eventually.
Are there changes in behavior for the user?
No, but maybe there should be. Telling the user they are responsible about URL correctness is not particularly useful if the specific correctness properties are not enumerated.
Related issue number
Still roughly the same scenario, just moved from aio-libs/aiohttp#8088 where it was unnecessarily tested for, and thus failed on PyPy
Checklist