Skip to content

Conversation

@webknjaz
Copy link
Member

@webknjaz webknjaz commented Jun 23, 2025

What do these changes do?

This is an infra change that generalizes the cibuildwheel workflow as a part of preparation to my effort of further extraction externally.

This includes having input names in line with reusable-tox.yml and configuring cibuildwheel via env vars passed through inputs.

Are there changes in behavior for the user?

Nope.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@webknjaz webknjaz self-assigned this Jun 23, 2025
@webknjaz webknjaz requested a review from asvetlov as a code owner June 23, 2025 18:40
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 23, 2025

CodSpeed Performance Report

Merging #1193 will degrade performances by 26.04%

Comparing webknjaz:maintenance/generic-gha-cibuildwheel (0072f7e) with master (5ab49a5)

Summary

❌ 3 regressions
✅ 241 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_getall_istr_miss[py] 177.6 µs 236.4 µs -24.85%
test_multidict_getall_str_hit[cs-py] 1.8 ms 2.2 ms -17.22%
test_multidict_getall_str_miss[ci-py] 174 µs 235.3 µs -26.04%

webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from ce4424d to 0f49f9f Compare June 23, 2025 18:56
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from 0f49f9f to e0aeedf Compare June 23, 2025 19:01
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from e0aeedf to 08ba072 Compare June 23, 2025 19:15
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from 08ba072 to 525c1c1 Compare June 23, 2025 19:32
webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 23, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from 525c1c1 to 68b14b4 Compare June 23, 2025 19:37
@asvetlov
Copy link
Member

@webknjaz could you wait for tomorrow please.
The PR looks promising but I'm too tired now, I'd like to carefully review next day.

@webknjaz
Copy link
Member Author

I don't need a review, really. It's thing I'll be hosting outside aio-libs, eventually. This is to ease the migration.

webknjaz added a commit to webknjaz/multidict that referenced this pull request Jun 24, 2025
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from 68b14b4 to e5e92b9 Compare June 24, 2025 00:20
@webknjaz webknjaz force-pushed the maintenance/generic-gha-cibuildwheel branch from e5e92b9 to 0072f7e Compare June 24, 2025 00:55
@webknjaz webknjaz merged commit eeb048f into aio-libs:master Jun 24, 2025
14 checks passed
@asvetlov
Copy link
Member

I don't need a review, really. It's thing I'll be hosting outside aio-libs, eventually.

It scares me a little. Is there any chance of having write access to these outside things for aio-libs admins?
In case something breaks in the future?

@webknjaz
Copy link
Member Author

It's going to be PyPA so no. But I'm not migrating just yet. I need to solve a few things and document usage strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants