Skip to content

Conversation

@finnagin
Copy link
Contributor

@finnagin finnagin commented May 21, 2025

What do these changes do?

This would add builds for and run tests on arm64 windows wheels

Are there changes in behavior for the user?

No

Related issue number

Fixes #1166

Checklist

  • I think the code is well written (I hope so!)
  • Unit tests for the changes exist
  • Documentation reflects the changes

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Performance Report

Merging #1167 will not alter performance

Comparing finnagin:arm64-runner (b933347) with master (874fc89)

Summary

✅ 244 untouched benchmarks

@finnagin
Copy link
Contributor Author

finnagin commented May 21, 2025

The earliest python version that actions/setup-python supports for windows arm64 is 3.11 so I skipped the arm64 wheel tests for 3.9 & 3.10 but CIBuildWheel does build wheels for those versions and they pass the tests that it runs. Does that seem reasonable to skip those later tests in the workflow?

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finnagin thanks for the PR!
How is ARM Windows different from x64?
From my understanding, API should be the same, at least for a subset af calls used by multidict.
Does it make sense to drop windows-11-arm from test job matrix but leave it in build-wheels job?
It doesn't waste additional CI time but provides the same level of test coverage since tests run as a part of the wheel building.

@finnagin
Copy link
Contributor Author

Does it make sense to drop windows-11-arm from test job matrix but leave it in build-wheels job?
It doesn't waste additional CI time but provides the same level of test coverage since tests run as a part of the wheel building.

Sure! That makes sense to me. I can do that.

@finnagin finnagin requested a review from asvetlov May 27, 2025 23:15
@asvetlov asvetlov merged commit fa9e4b6 into aio-libs:master May 29, 2025
64 checks passed
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Windows arm64 wheels

2 participants