-
-
Notifications
You must be signed in to change notification settings - Fork 113
Add Windows arm64 builds #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows arm64 builds #1167
Conversation
CodSpeed Performance ReportMerging #1167 will not alter performanceComparing Summary
|
|
The earliest python version that actions/setup-python supports for windows arm64 is 3.11 so I skipped the arm64 wheel tests for 3.9 & 3.10 but CIBuildWheel does build wheels for those versions and they pass the tests that it runs. Does that seem reasonable to skip those later tests in the workflow? |
asvetlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finnagin thanks for the PR!
How is ARM Windows different from x64?
From my understanding, API should be the same, at least for a subset af calls used by multidict.
Does it make sense to drop windows-11-arm from test job matrix but leave it in build-wheels job?
It doesn't waste additional CI time but provides the same level of test coverage since tests run as a part of the wheel building.
Sure! That makes sense to me. I can do that. |
|
Thanks! |
What do these changes do?
This would add builds for and run tests on arm64 windows wheels
Are there changes in behavior for the user?
No
Related issue number
Fixes #1166
Checklist