-
-
Notifications
You must be signed in to change notification settings - Fork 33
Add windows arm64 support #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macos was failing skipping temporarily to test arm64 build
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me I wish I had perms to let it through but hopefully now that I have reviewed it someone will notice
|
@finnagin Would you please update this one as well |
|
I had already started the release in #698 when I saw this one I'm assuming you don't want to wait 6 months for the next release so I'll wait till this finishes and redo the release PR |
Thanks! I really appreciate that @bdraco ! |
What do these changes do?
This would add windows arm64 wheel builds and tests
Are there changes in behavior for the user?
Would provide a native wheel for arm64 Windows users
Related issue number
Fixes #677
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.