[PR #9832/006f4070 backport][3.10] Increase allowed import time for Python 3.12/3.13 to 265 #9833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 006f407)
bdraco
approved these changes
Nov 12, 2024
CodSpeed Performance ReportMerging #9833 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #9833 +/- ##
==========================================
+ Coverage 97.74% 97.92% +0.17%
==========================================
Files 113 113
Lines 35816 35821 +5
Branches 4303 4314 +11
==========================================
+ Hits 35007 35076 +69
+ Misses 595 553 -42
+ Partials 214 192 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.10/006f4070c7f64f4aacbec2795b772bf76c4efd66/pr-9832
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9832 as merged into master (006f407).
I ran a profile of the imports and did not find any one thing that was causing the import time to jump up. The bulk of the time outside of bootstrap is spent in typing.py, and since we do not want to discourage adding more typing it seems like we need to increase this.
Additional discussion in #9828 (comment)