Update update_query calls to work with latest yarl #7260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7260 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 107 107
Lines 31484 31485 +1
Branches 3937 3937
=======================================
+ Hits 30639 30640 +1
Misses 641 641
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This patch pass "{}" when params is "None" to the url.update_query to
avoid setting the url params to None.
Related to this change in yarl:
aio-libs/yarl@dd86b34
Fix aio-libs#7259
psf-chronographer
bot
added
the
bot:chronographer:provided
Contributor
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #7271 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 2, 2023
This patch pass "{}" when params is "None" to the url.update_query to
avoid setting the url params to None.
Related to this change in yarl:
aio-libs/yarl@dd86b34
Fix #7259
---------
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 2be9318)
Dreamsorcerer
pushed a commit
that referenced
this pull request
May 2, 2023
…ith latest yarl (#7271) **This is a backport of PR #7260 as merged into master (2be9318).** This patch pass "{}" when params is "None" to the url.update_query to avoid setting the url params to None. Related to this change in yarl: aio-libs/yarl@dd86b34 Fix #7259 Co-authored-by: danigm <[email protected]>
1 task
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch pass "{}" when params is "None" to the url.update_query to avoid setting the url params to None.
Related to this change in yarl:
aio-libs/yarl@dd86b34
Fix #7259