Skip to content

Add number of bytes to stream.read_nowait #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2015
Merged

Add number of bytes to stream.read_nowait #700

merged 1 commit into from
Dec 28, 2015

Conversation

@eyal-stratoscale
Copy link
Contributor

@eyal-stratoscale eyal-stratoscale commented Dec 22, 2015

No description provided.

@fafhrd91
Copy link
Member

fafhrd91 commented Dec 22, 2015

what is the reason?

@eyal-stratoscale
Copy link
Contributor Author

eyal-stratoscale commented Dec 22, 2015

The private method accepts number of bytes, I don't understand why the public one shouldn't expose this feature.
plus, I need this feature :-)

@eyal-stratoscale
Copy link
Contributor Author

eyal-stratoscale commented Dec 28, 2015

@fafhrd91 , can you please merge this pull request?

fafhrd91 added a commit that referenced this pull request Dec 28, 2015
@fafhrd91
Merge pull request #700 from eyal-stratoscale/master
fa17261 
Add number of bytes to stream.read_nowait
@fafhrd91 fafhrd91 merged commit fa17261 into aio-libs:master Dec 28, 2015
@fafhrd91
Copy link
Member

fafhrd91 commented Dec 28, 2015

Sure

@eyal-stratoscale
Copy link
Contributor Author

eyal-stratoscale commented Dec 28, 2015

Thanks

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyal-stratoscale @fafhrd91