Bump RDMA memory check UCX version#1445
Conversation
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
📝 WalkthroughWalkthroughA UCX version threshold for RDMA memory type validation in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/plugins/ucx/ucx_utils.cpp`:
- Around line 643-644: The code incorrectly checks against a non-existent UCX
version UCP_VERSION(1,22); change the threshold in ucx_utils.cpp where
ucpVersion_ is compared (the if (ucpVersion_ >= UCP_VERSION(1, 22)) check) to
the correct existing release macro (use UCP_VERSION(1, 20) to match UCX
v1.20.0), and also update the corresponding test reference in
test/gtest/hw_warning_test.cpp (replace UCP_VERSION(1, 21) with UCP_VERSION(1,
20)) so both the runtime check and the test use the same valid UCX version
macro.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0be1637e-1428-41db-a5b8-49fcabe9be24
📒 Files selected for processing (1)
src/plugins/ucx/ucx_utils.cpp
|
/build |
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
What?
Bump RDMA memory check UCX version
Why?
To be handled in UCX 1.22
Summary by CodeRabbit