-
Notifications
You must be signed in to change notification settings - Fork 176
[NOTICE]: Moved this to DrKJeff16/project.nvim
#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guennadi Maximov C <[email protected]>
Switched deprecated functions to supported ones, and thus accomodated code.
Let's not redefine identifiers please. Switch them to a more suitable name.
`vim.loop` is still supported, but only as a fallback.
DrKJeff16
commented
Aug 8, 2024
- Added annotations for almost every section that warranted it... except for Telescope, that's a pending one... - Fixed some statements assigned in the wrong scope - Added structured names for all non-telescope modules - Some TODOS/etc. were added - Formatting issues Overall, annotations are working as intended and, as far as I've been able to test, none of my code fixes break anything. Signed-off-by: Guennadi Maximov C <[email protected]>
- Fixed some `var == false` `if` statements as they were redundant - Simplified code logic (e.g. removed unnecessary code blocks) - Moved variable declaration to correct scope instead of inside a loop Signed-off-by: Guennadi Maximov C <[email protected]>
- Fixed some `var == false` `if` statements as they were redundant - Switched dictionary-like call to field call in table statement Signed-off-by: Guennadi Maximov C <[email protected]>
- Added annotations for almost every section that warranted it... except for Telescope, that's a pending one... - Fixed some statements assigned in the wrong scope - Added structured names for all non-telescope modules - Some TODOS/etc. were added - Formatting issues Overall, annotations are working as intended and, as far as I've been able to test, none of my code fixes break anything. Signed-off-by: Guennadi Maximov C <[email protected]>
- Fixed some `var == false` `if` statements as they were redundant - Simplified code logic (e.g. removed unnecessary code blocks) - Moved variable declaration to correct scope instead of inside a loop Signed-off-by: Guennadi Maximov C <[email protected]>
- Fixed some `var == false` `if` statements as they were redundant - Switched dictionary-like call to field call in table statement Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Since indentation is variable across users, make sure to enforce it when opening Lua files using (Neo)Vim. Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Since indentation is variable across users, make sure to enforce it when opening Lua files using (Neo)Vim. Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Author
|
Well, crap. I messed up the commit history :p, I'll try and fix it later. Looks horrible. I hate |
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Personally I think using `next()` is a general purpose solution, rather than alternating between `ipairs()` and `pairs()`. Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
This reverts commit 9a0ad6b.
…gs). Signed-off-by: Guennadi Maximov C <[email protected]>
* Favour using `string.format()` over string concatenation * Decreased complexity for certain code blocks * Renamed identifiers * Other useless, style stuff Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Credits to: ahmedkhalf/project.nvim#164 Signed-off-by: Guennadi Maximov C <[email protected]>
DrKJeff16/project.nvim
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR
NOTE: DON'T MERGE THIS PR YET (if you were ever planning to do so). I partially added some annotations and
took the liberty to make some minimal code corrections myself... well, except for
Telescope.See Edit 1 for the details.See Edit 2 for an update.
TOC
[2024-08-12]TL;DR
This is an attempt to fix #153 - related issues.
My fork will be maintained regularly by for the foreseeable future as this seems unmaintained,
and so I'll attempt to resolve issues and add documentation in particular.
Changes List
vim.api.nvim_buf_get_clients==>vim.api.nvim_get_clientsvim.api.nvim_get_current_buf()to determine current buffer (a pet-peeve of mine, but will revert to 0 if needed)vim.uvovervim.loopif availableAny feedback is appreciated c:
Edits
[2024-08-08]
Added some annotations to some files and made some code fixes. Telescope is missing.
It's still a WIP, so I'd really like some feedback from you, but I'll continue
with the changes for now.
If you have any comment, I'll make sure to rollback/fix/extend my contributions with your suggestions in mind.
Sample (
lua/project_nvim/config.lua):[2024-08-12]
@ahmedkhalf (Sorry for the ping btw) I have documented the code for good, and done my part for this PR. If you have any feedback please let me know. I'll also gladly keep making PRs for fixes/additions for this plugin if warranted.I thank you for your attention c: