📦 NEW: Compile multiple CSS files into different directories#125
📦 NEW: Compile multiple CSS files into different directories#125mintbird wants to merge 5 commits intoahmadawais:masterfrom
Conversation
IMPROVE: Docs Syntax
Add full stop at the end of the line.
ahmadawais
left a comment
ahmadawais
left a comment
There was a problem hiding this comment.
Thanks for the awesome PR. Take a look at the comments.
src/gulpfile.babel.js
Outdated
| var tasks = config.addonStyles.map( function ( addon ) { | ||
|
|
||
| return gulp | ||
| .src( addon.styleSRC, { allowEmpty: true }) |
There was a problem hiding this comment.
I wish there was less repetition. This styles task is repeated four times now, maybe we can make a function that can be used everywhere in styles, stylesRTL and addonStyles/RTL tasks? Would you be up for it?
1. New function processStyle() for process any selected SCSS files with RTL option. 2. Remove example of addonStyles from configuration file and add description in README.md
|
Fixed from your comment. All pipes related to processing SCSS file was moved to the new function processStyle and the example configuration was removed and described in README.md instead. |
README.md
Outdated
|
|
||
|  | ||
|
|
||
| #### Add-on Styles Option |
There was a problem hiding this comment.
This is not the right place for content like this. Kindly, create a new heading after installation call it, FAQs, ask a question and then answer it. 👍
src/gulpfile.babel.js
Outdated
| */ | ||
| gulp.task( 'styles', () => { | ||
| return processStyle( | ||
| gulp.src( config.styleSRC, { allowEmpty: true }) |
src/gulpfile.babel.js
Outdated
| function processStyle( gulpStream, processOptions = {} ) { | ||
| processOptions = defaults( processOptions, { | ||
| isRTL: false, | ||
| styleDestination: './', |
There was a problem hiding this comment.
Even with simple styles the styleDestination should always be provided for folks who change the location of it for some reason.
|
To write commits for this repo, it's important that you follow the Emoji-log commit standard. Otherwise, I'll have to squash everything into one single commit. And you'll get only one commit contribution props. Also check the changes I asked for. This PR is looking pretty good. |
|
Fixed. You can squash the commits. |
|
When can this be merged? |
5 participants
Description
Refer to #103 Add capability to compile multiple CSS files into different directories
With this feature, user can add scss files and specify the location of compiled css file for each scss file.
The steps of compilation and configuration is the same as task "styles" and "stylesRTL".
The new task "addonStyles" will be processed with "config.watchStyles"
Screenshots:
No.
Types of changes
NEW: Compile multiple CSS files into different directories
How Has This Been Tested?
Tested with the default configuration
Empty configuration "addonStyles" will not bug the task.
Checklist: