Skip to content
This repository was archived by the owner on Apr 7, 2025. It is now read-only.

Add environment_vars config#51

Merged
ahelal merged 3 commits intoahelal:masterfrom
syndbg:environment-vars
Feb 19, 2019
Merged

Add environment_vars config#51
ahelal merged 3 commits intoahelal:masterfrom
syndbg:environment-vars

Conversation

@syndbg
Copy link
Contributor

@syndbg syndbg commented Dec 18, 2018

Adds environment_vars config.

Why

This is very much needed when using an inventory source script such as ec2.py, proxmox.py and similar since you have to pass your authentication credentials via environment variables and/or files. Files are obviously not sufficient enough for dynamic test suites.

So with this change usage is

provisioner:
  name: ansible_push
  extra_vars:
    FOO: bar

Anything other than a Hash will be marked as invalid configuration. E.g

provisioner:
  name: ansible_push
  extra_vars: []

Also changed

Bumped version to minor version 0.10.0, since we're introducing new functionality.

@ahelal

@ahelal
Copy link
Owner

ahelal commented Dec 19, 2018

Hi @syndbg,
thank you for the PR, I am currently with limited internet. I will have a look in mid Jan.

Happy new year 🎆

@ahelal
Copy link
Owner

ahelal commented Feb 15, 2019

Hi i @syndbg,
Sorry for the delay can you rebase the pr ? so i can merge

@syndbg
Copy link
Contributor Author

syndbg commented Feb 15, 2019

@ahelal Yes, sure. Rebased.

Also noticed that I didn't add any documentation about the existence of environment_vars. Added in bbd5f88

Imo it's good to merge.

@syndbg
Copy link
Contributor Author

syndbg commented Feb 15, 2019

Ping @ahelal :)

@ahelal ahelal merged commit 20eefbd into ahelal:master Feb 19, 2019
@syndbg syndbg deleted the environment-vars branch February 19, 2019 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants