Merged
Conversation
…reaks The test fails without this commit because the mypy output creates line breaks and the excepted output doesn't account for that. Fixed by remove unnecessary line breaks via regex.
for more information, see https://pre-commit.ci
Owner
|
I'll take a look at this over the weekend. |
agronholm
reviewed
Feb 16, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #510
In 889ad53 the parameters of check_variable_assignment in _functions.py were changed but one call in _transformer.py wasn't adjusted. Fixed by adjusting mentioned call and changing tests accordingly.
Furthermore, I had to change how the test handles mypy output because otherwise I couldn't get the tests to pass (even on the unmodified version). (see 5336b1c)
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).