Skip to content

fix: initialize ModelResponse to avoid errors #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix: initialize ModelResponse to avoid errors #5185

wants to merge 3 commits into from

Conversation

@Mustafa-Esoofally
Copy link
Contributor

@Mustafa-Esoofally Mustafa-Esoofally commented Oct 24, 2025 •
edited
Loading

Summary

Initialize ModelResponse to avoid downstream errors

Call chain

  1. agent.py line 4627 calls model.aresponse_stream()
  2. base.py line 1070 (inside aresponse_stream) calls self.aprocess_response_stream()
  3. base.py line 1003-1021

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement
  • Model update
  • Other:

Checklist

  • Code complies with style guidelines
  • Ran format/validation scripts (./scripts/format.sh and ./scripts/validate.sh)
  • Self-review completed
  • Documentation updated (comments, docstrings)
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable)
  • Tested in clean environment
  • Tests added/updated (if applicable)

@Mustafa-Esoofally Mustafa-Esoofally requested a review from a team as a code owner October 24, 2025 19:31
@linear
Copy link

linear bot commented Oct 24, 2025

SUP-1313 [Bug] UnboundLocalError: cannot access local variable 'model_response' where it is not associated with a value

@uzaxirr
Copy link
Contributor

uzaxirr commented Oct 25, 2025

closes: #5083

uzaxirr
uzaxirr reviewed Oct 25, 2025
View reviewed changes
Copy link
Contributor

@uzaxirr uzaxirr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mustafa-Esoofally Mustafa-Esoofally marked this pull request as draft October 31, 2025 19:10
@linear
Copy link

linear bot commented Oct 31, 2025

SUP-1313 [Bug] 'AsyncPostgresDb.get_sessions' was never awaited

@manuhortet
Copy link
Contributor

manuhortet commented Nov 5, 2025

This was solved with #5303

@manuhortet manuhortet closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzaxirr uzaxirr uzaxirr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mustafa-Esoofally @uzaxirr @manuhortet