feat: improve session storage in-memory #5179
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbrnd
reviewed
Oct 24, 2025
| session_type: SessionType, | ||
| user_id: Optional[str] = None, | ||
| deserialize: Optional[bool] = True, | ||
| num_history_runs: Optional[int] = None, |
There was a problem hiding this comment.
Wouldn't it be more general to call this max_runs or something similar. "History" doesn't make sense in the data layer
dirkbrnd
reviewed
Oct 24, 2025
|
|
||
| log_debug(f"Session: {session}") | ||
|
|
||
| # Limit the number of runs to the specified number if num_history_runs is specified |
There was a problem hiding this comment.
This has to be offloaded to the DB if we can, otherwise it defeats the purpose right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now filter out the runs needed for the Session instead of keeping the entire Session in-memory
(If applicable, issue number: #____)
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)