Add tests showing code that fails in 1.5 that worked in 1.4#675
Open
osmestad wants to merge 1 commit intoagiledigital:masterfrom
Open
Add tests showing code that fails in 1.5 that worked in 1.4#675osmestad wants to merge 1 commit intoagiledigital:masterfrom
osmestad wants to merge 1 commit intoagiledigital:masterfrom
Conversation
It seems the type inferencing changes on arguments in 1.5 breaks a few patterns in our code. Added two examples with `call` where the argument passed is part of a union of values, this now fails as type errors. For strings I'm able to work around it with using `as const`, but for numbers I do not think that is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the type inferencing changes on arguments in 1.5 breaks a few patterns in our code.
Added two examples with
callwhere the argument passed is part of a union of values, this now fails as type errors. For strings I'm able to work around it with usingas const, but for numbers I do not think that is possible.I had a look at the code changes in #654 but I'm not sure if there is any easy way to fix this?