Skip to content

Conversation

@DavdGao
Copy link
Member

@DavdGao DavdGao commented Oct 3, 2025

AgentScope Version

[The version of AgentScope you are working on, e.g. import agentscope; print(agentscope.__version__)]

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with pre-commit run --all-files command
  • All tests are passing
  • Docstrings are in Google style
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@DavdGao DavdGao requested a review from Copilot October 3, 2025 08:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug in plan notebook serialization where the custom_to_json function was returning a JSON string instead of a dictionary, causing serialization issues.

  • Changed model_dump_json() to model_dump() in the PlanNotebook class for proper state serialization
  • Added comprehensive test case to verify serialization and deserialization functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/agentscope/plan/_plan_notebook.py Fixed serialization bug by changing model_dump_json() to model_dump()
tests/plan_test.py Added test case to verify plan notebook serialization works correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DavdGao DavdGao merged commit 1a6505a into agentscope-ai:main Oct 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant