Skip to content

Conversation

@AIGCool
Copy link
Contributor

@AIGCool AIGCool commented Oct 3, 2025

AgentScope Version

[v1.0.4]

Description

[Added support for milvus lite vector database in the RAG module of AgentScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.]

Checklist

Add agentscope/src/agentscope/rag/_store/_milvuslite_store.py
Add agentscope/examples/functionality/rag/milvuslite_store.py

Update agentscope/src/agentscope/rag/_store/init.py
Update agentscope/src/agentscope/rag/init.py

…entScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.
Copy link
Contributor Author

@AIGCool AIGCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for milvus lite vector database in the RAG module of AgentScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.

@DavdGao DavdGao self-requested a review October 9, 2025 07:54
@DavdGao
Copy link
Member

DavdGao commented Oct 14, 2025

Thanks for your contribution. Please install pre-commit and run the checking by the following commands:

pip install pre-commit
pre-commit install
pre-commit run --all-files

Copy link
Member

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments. If you don't mind, I'd be happy to submit some changes directly to this branch to help get it merged quickly.

@DavdGao DavdGao changed the title Main Add support for milvus lite vector database in the RAG module of AgentScope Oct 14, 2025
@DavdGao DavdGao added Roadmap The development plan RAG labels Oct 14, 2025
1. Create a new folder called vector_store in the `examples/functionality` directory and move the `milvuslite_store.py` file to this folder.
2. Fix the invalid `src_path` declaration and usage in `examples/functionality/rag/milvuslite_store.py`.
3. Use `pre-commit` to verify the newly added classes.
Copy link
Contributor Author

@AIGCool AIGCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update contains the following:

  1. Create a new folder called vector_store in the `examples/functionality` directory and move the `milvuslite_store.py` file to this folder.
  2. Fix the invalid `src_path` declaration and usage in `examples/functionality/rag/milvuslite_store.py`.
  3. Use `pre-commit` to verify the newly added classes.

Copy link
Member

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao linked an issue Oct 21, 2025 that may be closed by this pull request
10 tasks
@DavdGao DavdGao merged commit e900d9c into agentscope-ai:main Oct 21, 2025
10 checks passed
@AIGCool
Copy link
Contributor Author

AIGCool commented Oct 21, 2025

Thank's for your previous guidance and recognition of my submission. I hope this project can help more users improve the people they support. I will continue to pay attention to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RAG Roadmap The development plan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend the current RAG implementation

2 participants