-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for milvus lite vector database in the RAG module of AgentScope #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…entScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support for milvus lite vector database in the RAG module of AgentScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.
|
Thanks for your contribution. Please install pre-commit and run the checking by the following commands: pip install pre-commit
pre-commit install
pre-commit run --all-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments. If you don't mind, I'd be happy to submit some changes directly to this branch to help get it merged quickly.
1. Create a new folder called vector_store in the `examples/functionality` directory and move the `milvuslite_store.py` file to this folder. 2. Fix the invalid `src_path` declaration and usage in `examples/functionality/rag/milvuslite_store.py`. 3. Use `pre-commit` to verify the newly added classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update contains the following:
- Create a new folder called vector_store in the `examples/functionality` directory and move the `milvuslite_store.py` file to this folder.
- Fix the invalid `src_path` declaration and usage in `examples/functionality/rag/milvuslite_store.py`.
- Use `pre-commit` to verify the newly added classes.
# Conflicts: # setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank's for your previous guidance and recognition of my submission. I hope this project can help more users improve the people they support. I will continue to pay attention to this project. |
AgentScope Version
[v1.0.4]
Description
[Added support for milvus lite vector database in the RAG module of AgentScope, with an instance of milvuslitestore.py, and created a collection of corresponding examples, with an instance of milvuslitestoreexample.py.]
Checklist
Add agentscope/src/agentscope/rag/_store/_milvuslite_store.py
Add agentscope/examples/functionality/rag/milvuslite_store.py
Update agentscope/src/agentscope/rag/_store/init.py
Update agentscope/src/agentscope/rag/init.py