-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add RAG module into AgentScope #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a comprehensive Retrieval-Augmented Generation (RAG) module to AgentScope that supports both multimodal data and traditional text-based RAG functionality. The module provides document readers, vector database stores, knowledge bases, and integrates with embedding models to enable document-based question answering capabilities.
Key changes:
- New RAG module with document readers (TextReader, PDFReader) for data chunking
- Vector database store abstractions with Qdrant implementation for document storage
- Knowledge base system supporting multimodal embeddings
- Integration of RAG capabilities into ReActAgent through knowledge parameter
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/agentscope/rag/ | Core RAG module with document, reader, store, and knowledge base implementations |
| src/agentscope/embedding/ | Updated embedding models to support dimensions and multimodal data |
| src/agentscope/agent/_react_agent.py | Added knowledge parameter to ReActAgent for RAG integration |
| tests/tracer_test.py | Updated test to reflect embedding model constructor changes |
| examples/functionality/rag/ | Example usage scripts demonstrating basic and agentic RAG workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# Conflicts: # src/agentscope/agent/_react_agent.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 46 out of 47 changed files in this pull request and generated 10 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 47 out of 48 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 46 out of 47 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AgentScope Version
1.0.4
Description
QdrantStoreSimpleKnowledgeTextReaderand a basic PDF reader classPDFReaderDashScopeMultiModalEmbeddingDashScopeTextEmbeddingReActAgent, and 4) multimodal RAGDashScopeMultiModalEmbeddingChecklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand