Skip to content

Conversation

@DavdGao
Copy link
Member

@DavdGao DavdGao commented Aug 27, 2025

AgentScope Version

1.0.0

Description

  • Enriched the current README.md and README_zh.md;
  • Fix the bug in the handle_interrupt method of ReActAgent
  • Fix the bug in formatter that cannot handle string output in tool result block

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with pre-commit run --all-files command
  • All tests are passing
  • Docstrings are in Google style
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@DavdGao DavdGao requested a review from Copilot August 27, 2025 02:56
@DavdGao DavdGao added Bug Something doesn't work Documentation Improvements or additions to documentation Ready for Review labels Aug 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the AgentScope framework by enriching README documentation, fixing a critical bug in the ReActAgent's interrupt handling mechanism, and improving the formatter's tool result handling capabilities.

  • Fixed memory clearing bug in ReActAgent's handle_interrupt method that was inappropriately clearing memory during interruptions
  • Enhanced formatter to properly handle string outputs in tool result blocks
  • Significantly enriched README.md and README_zh.md with new features, examples, and improved documentation structure

Reviewed Changes

Copilot reviewed 7 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/agentscope/formatter/_formatter_base.py Enhanced convert_tool_result_to_string method to handle string inputs alongside list inputs
src/agentscope/agent/_react_agent.py Fixed bug by removing inappropriate memory clearing in handle_interrupt method
examples/react_agent/main.py Changed UserAgent name from "Bob" to "User" for consistency
examples/game/werewolves/README.md Improved formatting and documentation clarity for the werewolves game example
README_zh.md Major enrichment with new features, examples, and improved structure
README.md Major enrichment with new features, examples, and improved structure
.github/workflows/toc.yml Added GitHub workflow for automatic table of contents generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DavdGao DavdGao requested a review from qbc2016 August 27, 2025 03:18
Copy link
Member

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DavdGao DavdGao merged commit a7c5c3f into agentscope-ai:main Aug 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something doesn't work Documentation Improvements or additions to documentation Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants