Revise definitions of Data.List.Base.scanl|inits; add Data.List.NonEmpty.Base.scanl⁺|inits⁺
#2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hmmm, looks as though I've screwed up the |
Collaborator
|
Yes, other than that, this looks really good! |
Collaborator
Author
|
Hopefully that's sorted out now. |
Collaborator
Author
|
So I think we've (now) agreed to find a better home for this (and #2258 ) under |
Collaborator
Author
|
Aaargh: |
andreasabel
reviewed
May 22, 2024
Member
andreasabel
left a comment
andreasabel
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
In general, some list operations always return non-empty lists, so this should be expressed in types; and then one can choose to forget the extra information of non-emptiness using a conversion to plain lists.
Collaborator
Author
|
Now see #2395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2267 . See also the discussion on #2258 .