Simplify some Relation.Binary imports
#2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
commented
Jun 27, 2023
JacquesCarette
approved these changes
Jul 6, 2023
Saransh-cpp
commented
Jul 6, 2023
Member
|
Does anyone have any objection to merging this and the similar PRs? I think they've sat open long enough |
Collaborator
|
I'd like some truly independent person to do a final review (perhaps @gallais ?) before doing so. |
gallais
approved these changes
Jul 28, 2023
Merged
MatthewDaggitt
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Simplify some `Relation.Binary` imports * Format * Better naming scheme * Fix tests * Merge issues
andreasabel
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Simplify some `Relation.Binary` imports * Format * Better naming scheme * Fix tests * Merge issues
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not get rid of all the
Relation.Binaryimports. I'll be creating PRs for the same.