Fix all controls to use id instead of idPrefix on tracked-controls

[vincentfretin]

Description:

Fix all controls to use id instead of idPrefix when setting the tracked-controls component, only logitech-mx-ink-controls and meta-touch-controls were correct (fix #5772)

The tests pass with three 177

[vincentfretin]

That would be good if someone having one of those headset could verify this is working properly.
Does the controllers worked at all on the aframe 1.7.1 release? And what about now with the PR?

[dmarcos]

thanks!

[mrxz]

That would be good if someone having one of those headset could verify this is working properly.
Does the controllers worked at all on the aframe 1.7.1 release? And what about now with the PR?

Haven't run any tests, but I do recall testing it when removing the webvr variant and not running into any issues. I believe it still works due to the following pattern in the components:

• checkIfControllerPresent filters correctly on the GAMEPAD_ID
• If a matching controller is found the injectTrackedControls method is called
• The invalid idPrefix property is set, meaning id ends up being the default (empty string)
• tracked-controls uses controllerUtils.findMatchingControllerWebXR , which now matches any controller.

In short, there are two checks/filters that use a different ID value. The former still guarantees the right xyz-controls becomes active, and the latter matches any and all controller (of the expected handedness). So this would've only caused issues in case there's more than one controller with the same handedness, which is very uncommon.

Looking at the overall flow, it would be nicer if there's only one lookup/check, completely avoiding the possibility of the two mismatching. But at least this fixes the potential issue for now.