Skip to content

Fix duplicate check in registerPropertyType #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix duplicate check in registerPropertyType #5475

merged 1 commit into from
Feb 27, 2024

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Feb 27, 2024

Description:
The check preventing duplicate propertyTypes from being registered incorrectly tested the string literal "type" instead of the type argument.

Changes proposed:

  • Fix the duplicate check in registerPropertyType
  • Throw an error instead of logging an error (in line with registerComponent, registerSystem, etc...)

@dmarcos
Copy link
Member

dmarcos commented Feb 27, 2024

Thanks!

@dmarcos dmarcos merged commit 233a29c into aframevr:master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrxz @dmarcos