Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Dec 9, 2023

Description:
Three.js gracefully handles objects with zero scale for quite a while now (mrdoob/three.js#17926, mrdoob/three.js#18885). As a result it's no longer needed for A-Frame to use an epsilon value to prevent scale from becoming zero along any or all axes.

For the animation component this also allows the animation to go from positive to negative or vice versa, which is currently prevented.

Changes proposed:

  • Remove epsilon value when scaling to 0 (with scale or animation component)

@dmarcos
Copy link
Member

dmarcos commented Dec 9, 2023

Thank you!

@dmarcos dmarcos merged commit ee7ec30 into aframevr:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants