Skip to content

Set renderer.useLegacyLights instead of renderer.physicallyCorrectLights #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

Set renderer.useLegacyLights instead of renderer.physicallyCorrectLights #5297

merged 1 commit into from
Jun 14, 2023

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Jun 5, 2023

Description:
Fixes #5293

Changes proposed:

  • Set renderer.useLegacyLights instead of the deprecated renderer.physicallyCorrectLights

@dmarcos
Copy link
Member

dmarcos commented Jun 14, 2023

Thanks so much!

@dmarcos dmarcos merged commit 4352692 into aframevr:master Jun 14, 2023
@vincentfretin vincentfretin mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning about physicallyCorrectLights that was renamed to useLegacyLights (three r152)

2 participants

@mrxz @dmarcos