- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.2k
Add Reverb G2 Support #4845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reverb G2 Support #4845
Conversation
| Thanks so much. This is the correct approach! Well done. I left a comment in the PR of the models. | 
| /** | ||
| * Rotate the trigger button based on how hard the trigger is pressed. | ||
| */ | ||
| onButtonChanged: function (evt) { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note. animate trigger and buttons on press if possible. If model is prepared for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to accept the hp-mixed-reality-controls without button animations initially, and then add button animations at a later time? That way Reverb G2 users will at least have a usable experience, rather than being stuck unable to use most a-frame apps.
| Thanks for sticking with this. Much appreciated. Have you checked if virtual and real controllers align? When integrating new controllers I test alignment by wearing headset and peeking inside / outside quickly to make sure the virtual and real controllers align? | 
| 
 Yes, the latest commit adds a position and rotation offset which aligns the model to both the WMR controller display and to the physical controller (at least within the margin of error allowed by the G2 tracking) | 
19689a8    to
    0347a0d      
    Compare
  
    | Thank you! | 
Description:
Adds the Reverb G2 controller as a supported controller
From #4823 (comment)
Additional Changes Needed: