Fixes #3592: Fix resolution drop on exiting VR mode #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomegz
force-pushed
the
aframe-3592-resolution-drop-on-mobile-fix
branch
from
041fe35 to
7a1f02f
Compare
|
I see that the tests are failing. I need to check why I can't access |
|
@tomegz Thanks. To fix the test you have to mock |
|
Done, sorry it took me so long. Please review @dmarcos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initial pixel ratio is set when setting up the renderer. After exiting VR mode it somehow gets reset. Additional
setPixelRatiocall on exiting VR mode fixes this issue.Changes proposed: