use self instead of this in sound.onEnded callback

[lazychip]

Description:
In sound component on sound ended isPlaying is not set to false

sound.onEnded = function () {
    this.isPlaying = false;
    el.emit('sound-ended', self.evtDetail, false);
};

Changes proposed:

• use self instead of this or change the onEnded callback function to arrow function.

sound.onEnded = function () {
    self.isPlaying = false;
    el.emit('sound-ended', self.evtDetail, false);
};

or

sound.onEnded = () => {
    this.isPlaying = false;
    el.emit('sound-ended', self.evtDetail, false);
};

[DigiTec]

Question for whomever does review this from the AFrame team.

Are we explicitly avoiding arrow functions to capture this?

If we are, should we instead be using the bind() helper instead of capturing a "self"? This would make things more consistent. We tend to use bind() for simple functions and any complex function wrappers we instead use self.

[dmarcos]

Yes, no arrow functions: Not supported in IE 11. As @DigiTec said probably bind a bit cleaner than self.